Translate: <progress> #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minyoung22222
requested review from
hg-pyun,
taehwanno,
simsim0709,
gnujoow,
b9words,
taggon,
MaxKim-J,
eomttt and
goofcode
as code owners
goofcode
reviewed
May 5, 2023
| @@ -16,36 +16,37 @@ The [built-in browser `<progress>` component](https://developer.mozilla.org/en-U | |||
|
|
|||
| --- | |||
|
|
|||
| ## Reference {/*reference*/} | |||
| ## 참조 {/*reference*/} | |||
There was a problem hiding this comment.
Glossary 에 명시된 대로 레퍼런스로 음역해 주시면 감사하겠습니다 🙇
goofcode
reviewed
May 5, 2023
|
|
||
| Additionally, `<progress>` supports these props: | ||
| * [`max`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#attr-max): 숫자. 최대`value`를 지정합니다. 기본값은 `1`입니다. |
goofcode
reviewed
May 5, 2023
|
|
||
| * [`max`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#attr-max): A number. Specifies the maximum `value`. Defaults to `1`. | ||
| * [`value`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#attr-value): A number between `0` and `max`, or `null` for intermedinate progress. Specifies how much was done. | ||
| * [`value`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#attr-value): `0`에서 `최대` 사이의 숫자 또는 중간 진행률의 경우 `null`입니다. |
There was a problem hiding this comment.
원문이 indeterminate 의 오타인 것 같네요. 😄
중간 진행률의 경우
→ 결정되지 않은 상태인 경우
→ 혹은 아래 번역해 주신 것과 같이 불확정 상태인 경우 도 좋을 것 같습니다.
|
@goofcode 피드백 감사합니다! 요청해주신 사항 수정 완료하여서 확인부탁드립니다! 🙇 |
gnujoow
approved these changes
May 9, 2023
hg-pyun
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress